chore: replace legacy Yarn with NPM #89
Conversation
jonkoops
force-pushed
the
replace-legacy-yarn
branch
from
289d0be to
efa5584
Compare
|
Looks like some older versions of Node.js don't like the new lockfile format, I will add some conditions there and mark this PR as a draft in the meantime. |
jonkoops
force-pushed
the
replace-legacy-yarn
branch
2 times, most recently
from
e753732 to
c0471d4
Compare
Signed-off-by: Jon Koops <[email protected]>
jonkoops
force-pushed
the
replace-legacy-yarn
branch
from
c0471d4 to
864e666
Compare
|
Managed to fix the issue by installing a more recent versions of NPM that is compatible with Node.js 14 conditionally. @rolandjitsu WDYT? |
Pull Request Test Coverage Report for Build 9046629b0188dfb48f797d03c30cd9ce8aab4984-PR-89Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 293aadd14759997a25f0a1de72d90200ee603e01-PR-89Details
💛 - Coveralls |
|
@jonkoops I still use yarn 😄 I don't think it's deprecated, it's a choice users can make via corepack (on latest node, a And we can also ensure that users use a specific version of yarn by adding a |
|
The only actively maintained version of Yarn is v4, the legacy version used here is v1, which has not been maintained since 2017. If you'd like I can upgrade the project with Yarn v4 instead, but it will come with some caveats:
Let me know what you'd like to do. |
|
@jonkoops I think it makes sense to transition back to npm in that case. So your changes are relevant. |
|
Can you merge this one in @rolandjitsu, or are there some changes you'd like to add? I have some other work ready to upgrade the GitHub Actions to the latest version that depends on this PR :) |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Replaces the legacy version of Yarn with regular NPM. This removes a now unsupported version of Yarn and makes it easier for folks looking to make a contribution since NPM will be installed on their system alongside with Node.js.
I considered using the new version of Yarn, but it would require users to enable Corepack, which is slated to be removed from Node.js in the next major. Using NPM simplifies things for users wishing to contribute.
Explain the motivation for making this change. What existing problem does the pull request solve?
Try to link to an open issue for more information.
Does this PR introduce a breaking change?
No.
Other information
None.